Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of KToken.sort from str to KSort in pyk.kast #2609

Merged
merged 4 commits into from
May 18, 2022
Merged

Change type of KToken.sort from str to KSort in pyk.kast #2609

merged 4 commits into from
May 18, 2022

Conversation

tothtamas28
Copy link
Contributor

@tothtamas28 tothtamas28 commented May 18, 2022 •
edited
Loading

Fixes #2602

@tothtamas28 tothtamas28 requested a review from ehildenb May 18, 2022 15:35
@tothtamas28 tothtamas28 self-assigned this May 18, 2022
radumereuta
radumereuta reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question.
I removed the automerge label. Feel free to add it back if you don't want to add the extra constructor.

pyk/src/pyk/kast.py Outdated Show resolved Hide resolved
@rv-jenkins rv-jenkins merged commit 795b422 into master May 18, 2022
@rv-jenkins rv-jenkins deleted the pyk-ktoken-sort branch May 18, 2022 22:44
@radumereuta radumereuta mentioned this pull request Aug 5, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehildenb ehildenb ehildenb approved these changes

@radumereuta radumereuta radumereuta left review comments

Assignees

@tothtamas28 tothtamas28

Labels
automerge pyk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KToken in pyk library should store a KSort, not a str
4 participants
@tothtamas28 @radumereuta @ehildenb @rv-jenkins