Add warning for syntax priority / associativity mismatch #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grab location information here and make sure it's preserved in the frontend KORE (not the same as backend Kore) that is produced: https://github.com/runtimeverification/k/blob/master/kernel/src/main/java/org/kframework/kore/convertors/KILtoKORE.java#L141 KIL are the flat parsed data-structures produced by the frontend outer parser. |
radumereuta
suggested changes
Jul 8, 2022
k-distribution/tests/regression-new/syntax-groups/syntaxGroups.k
Outdated
Show resolved
Hide resolved
kernel/src/main/java/org/kframework/compile/checks/CheckSyntaxGroups.java
Outdated
Show resolved
Hide resolved
radumereuta
approved these changes
Jul 14, 2022
dwightguth
approved these changes
Jul 19, 2022
5 tasks
h0nzZik
pushed a commit
to h0nzZik/k
that referenced
this pull request
Nov 24, 2022
…untimeverification#2132) * haskell-backend/src/main/native/haskell-backend: 75be3ad5a - Update regression tests (runtimeverification#2803) * haskell-backend/src/main/native/haskell-backend: edd0ca2a1 - Fixing trim-source-paths.sh for macos (runtimeverification#2791) * haskell-backend/src/main/native/haskell-backend: 32ecb98c2 - `SideCondition.definedTerms`: check if AC terms are always defined before caching them (runtimeverification#2800) * haskell-backend/src/main/native/haskell-backend: 6394bf2d - Remove _PREDICATE sort (runtimeverification#2719) * haskell-backend/src/main/native/haskell-backend: fd8775cc - Check function definitions tool (runtimeverification#2710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2460
This PR adds a compiler check that the labels in a syntax associativity sentence are not in different priority groups, and updates the relevant sections of the K tutorial and user manual to reflect this.
Note that the error message doesn't have location information, because the
SyntaxAssociativitysentence that I use in the check doesn't seem to include any - is there a better way to phrase this implementation?