-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example project for kompile --post-process
using pyk
#2729
Conversation
04d490b
to
8afdc6d
Compare
7fba7f9
to
1bf93f8
Compare
This looks great. I think we should have it committed somewhere in the K repo for future reference. Not in the root directory though. We should add it to the tests as well. You should let Amelie know about this. |
# virtualenv | ||
|
||
$(VENV): | ||
virtualenv -p python3.8 $(VENV_DIR) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line specifies the python version which is not stable on all machines.
For example, I have 3.10
It's going to be really annoying to change it to test on my local machine.
Can we do something about it?
This holds true for the test in the main pyk folder as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that moving towards supporting 3.10 as well would make sense (considering it's the Python version Ubuntu 22.04 uses). But right now, Python 3.8 is the only supported version for pyk
.
Fortunately, multiple Python versions can be installed on a given system from source without messing with the system's Python paths (make altinstall
): https://docs.python.org/3/using/unix.html#building-python
Virtualenv then can pick up the specified version from its install location.
Do you consider this a reasonable workaround for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for regression-new.
This test suite should be for quick testing and it should work on as many machines as possible.
If you move this test to the pyk folder then it should be fine. We already have this issue there.
This way, we keep regression-new worry free. You don't have to know yet another detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
666262f
to
853ab53
Compare
f4bfea1
to
f301523
Compare
d389ca2
to
4ebb160
Compare
4ebb160
to
16d34f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't make this work on my machine.
Ubuntu 22.04 can only build python 3.8.13.
I'm approving this for now, but we should really strive to support a wider range of versions. This is too frustrating.
The code lgtm
Related: #2558