Drop the tabulate dependency #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
force-pushed
the
pyk-drop-tabulate
branch
2 times, most recently
from
0c34de0 to
1ad65b1
Compare
tothtamas28
commented
Jul 22, 2022
| @@ -1,3 +1,4 @@ | |||
| import csv | |||
There was a problem hiding this comment.
Replaced tabulate with csv. The profile csv file can then be easily turned into a table by external tools. (Maybe we could even leave data processing / aggregation to external tools, and just write the raw profile data.)
ehildenb
approved these changes
Jul 22, 2022
tothtamas28
force-pushed
the
pyk-drop-tabulate
branch
from
1ad65b1 to
baa35bb
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2739