Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort declaration unparsing #2767

Merged
merged 7 commits into from
Aug 4, 2022
Merged

Fix sort declaration unparsing #2767

merged 7 commits into from
Aug 4, 2022

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Aug 2, 2022 •
edited
Loading

Bug in pyks unparser on KProduction that are just sort declarations.

  • Add failing test of unparsing a KProduction.
  • Add fix for said test.
  • Fix naming conventions in ktool/kprint.py.

Best reviewed commit-by-commit.

@ehildenb ehildenb self-assigned this Aug 2, 2022
@ehildenb ehildenb changed the title Fix sort declaration Fix sort declaration unparsing Aug 2, 2022
@ehildenb ehildenb marked this pull request as ready for review August 2, 2022 21:12
nishantjr
nishantjr suggested changes Aug 3, 2022
View reviewed changes
pyk/src/pyk/ktool/kprint.py Outdated Show resolved Hide resolved
@ehildenb ehildenb requested a review from nishantjr August 3, 2022 16:29
nishantjr
nishantjr suggested changes Aug 4, 2022
View reviewed changes
pyk/src/pyk/ktool/kprint.py Outdated Show resolved Hide resolved
pyk/src/pyk/tests/test_pretty_print_kast.py Show resolved Hide resolved
@ehildenb ehildenb requested a review from nishantjr August 4, 2022 17:02
@ehildenb ehildenb requested a review from gtrepta August 4, 2022 17:44
nishantjr
nishantjr approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@nishantjr nishantjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rv-jenkins rv-jenkins merged commit 84491b6 into master Aug 4, 2022
@rv-jenkins rv-jenkins deleted the fix-sort-declaration branch August 4, 2022 19:16
@radumereuta radumereuta mentioned this pull request Aug 5, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantjr nishantjr nishantjr approved these changes

@tothtamas28 tothtamas28 Awaiting requested review from tothtamas28

@radumereuta radumereuta Awaiting requested review from radumereuta

@gtrepta gtrepta Awaiting requested review from gtrepta

Assignees

@ehildenb ehildenb

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehildenb @nishantjr @rv-jenkins