Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add int-simplification builtin #2840

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Add int-simplification builtin #2840

wants to merge 3 commits into from

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Aug 30, 2022

This is a trimmed down version of KEVM's INT-SIMPLIFICATION module. It does not include the Java module that KEVM has, just the Haskell one. Opened this for discussion.

  • Documentation.
  • Tests.

@ehildenb ehildenb self-assigned this Aug 30, 2022
@radumereuta
Copy link
Contributor

We can make use of the comm attribute we just added.
This can be in domains.md in a separate module that is not imported by the INT module. Users can import it when they need it.

@ehildenb ehildenb changed the base branch from master to develop September 27, 2022 20:44
@Baltoli
Copy link
Contributor

Baltoli commented Oct 23, 2023

@ehildenb do you still want this upstreamed? It shouldn't be a huge effort to do so based on this old change; if not we can close the PR.

@Baltoli Baltoli closed this Oct 23, 2023
@Baltoli Baltoli reopened this Oct 23, 2023
@ehildenb
Copy link
Member Author

It would be nice to upstream eventually, but we should pull in latest changes from KEVM, and the tests from there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants