Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LLVM backend Python package #2849

Closed
wants to merge 22 commits into from
Closed

Use LLVM backend Python package #2849

wants to merge 22 commits into from

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Sep 1, 2022

This supersedes the draft changes in #2844 with a more robust solution as suggested by @tothtamas28.

The changes in this PR add the kllvm bindings as a "path" dependency to pyk, and updates the nix flake build accordingly. It also adds a trivial test case to make sure that pyk can call into the bindings correctly.

Because we point to a relative path dependency for the bindings library, we need to perform a few more steps for pyk's make install target. This issue gives some more context.

@Baltoli Baltoli changed the title Use LLVM backend package Use LLVM backend Python package Sep 1, 2022
@Baltoli
Copy link
Contributor Author

Baltoli commented Sep 1, 2022

python-poetry/poetry#5273 (comment) when debian packaging

@Baltoli Baltoli marked this pull request as ready for review September 2, 2022 16:11
@Baltoli Baltoli requested a review from a team as a code owner September 2, 2022 16:11
@Baltoli Baltoli requested a review from F-WRunTime September 6, 2022 15:26
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not clear to me how these changes would integrate with #2858 . You probably should coordinate in that regard and one of these two should be merged first. Probably that one, not this one.

@@ -1,3 +1,3 @@
/k-distribution/include/kframework/builtin/* @dwightguth @ehildenb
/Jenkinsfile @runtimeverification/admin
/.github/workflows/* @runtimeverification/admin
/Jenkinsfile @runtimeverification/admin @F-WRunTime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably more appropriate to just add Freeman to the admin team than to explicitly hardcode his username here.

@Baltoli
Copy link
Contributor Author

Baltoli commented Sep 9, 2022

Yes, I started working on this PR before I was aware of the work ongoing to pull Pyk out into its own repo. I will be coordinating with @tothtamas28 on the best way to get these changes working under that setup..

@Baltoli Baltoli closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants