Emit error from k frontend when kore-exec fails #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2022 15:34
kore-exec output can take up a lot of screen space. This change adds a error message to claify that the call to kore-exec either resulted in a stuck state or a crash when kore-exec returns a non-successful status.
SchmErik
requested review from
radumereuta
and removed request for
radumereuta
|
Do not use the word stuck since it has a different meaning in ML. |
added 2 commits
September 8, 2022 10:24
SchmErik
force-pushed
the
kprove-errors
branch
from
288c4d9 to
f2be328
Compare
radumereuta
approved these changes
Sep 14, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kore-exec output can take up a lot of screen space. This change adds a
error message to claify that the call to kore-exec either resulted in a
stuck state or a crash when kore-exec returns a non-successful status.
closes: #2576