Support Java 17 in kore submodule
#4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
approved these changes
Feb 23, 2024
rv-jenkins
pushed a commit
to runtimeverification/llvm-backend
that referenced
this pull request
Feb 23, 2024
This PR sets the Java version for `scala-maven-plugin` based on the parent POM, ensuring that we actually support Java 17 everywhere. Blocked on runtimeverification/k#4032. (Or should be? Not sure why the build is passing here when `${java.version}` hasn't been set in the master branch's parent POM yet.)
Baltoli
pushed a commit
to runtimeverification/llvm-backend
that referenced
this pull request
Feb 27, 2024
This PR sets the Java version for `scala-maven-plugin` based on the parent POM, ensuring that we actually support Java 17 everywhere. Blocked on runtimeverification/k#4032. (Or should be? Not sure why the build is passing here when `${java.version}` hasn't been set in the master branch's parent POM yet.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3736, we updated to Java 17 by configuring the Java version for
maven-compiler-plugin.However - after banging my head against a wall for the past hour wondering why none of my code is parsing 🙃 - I realized that the
koreandmatchingsubmodules are actually built byscala-maven-pluginrather thanmaven-compiler-plugin, and their Java version must be set independently.This PR sets the version for
koreto Java 17, and runtimeverification/llvm-backend#993 will do the same formatching.