[BUGFIX] Determining rule for getExitCode relies on top cell being named generatedTop #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehildenb you can't review this because you created it but please let me know if the fix looks good and if it does, I will approve. |
|
@dwightguth this seems to fix the immediate issue I was having, though I'm still having trouble building KEVM after changing the configuration slightly: runtimeverification/evm-semantics#335 The remaining issues have to do with the ocaml plugin though, not with this changeset, so this should be good to merge. |
…ng named <generatedTop>
ehildenb
force-pushed
the
exit-code-no-generated-top
branch
from
122ec38 to
87d699e
Compare
dwightguth
approved these changes
Apr 16, 2019
rv-jenkins
added a commit
that referenced
this pull request
May 5, 2021
…d Nix package with LTO (#407)
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling to the Kore/Haskell/LLVM backends, the logic here https://github.com/kframework/k/blob/cebb9ab45fc99f2c2b30df9401a50311f5a496ca/kernel/src/main/java/org/kframework/compile/GenerateSentencesFromConfigDecl.java#L486 assumes that some cell
<generatedTop>exists, which may not be the case (as this test demonstrates).