Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -r and -t options with common dirs (fixes #235) #249

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix -r and -t options with common dirs (fixes #235) #249

merged 1 commit into from
Sep 29, 2020

Conversation

ruduran
Copy link
Contributor

@ruduran ruduran commented Oct 1, 2018

Avoid using the common root when rank or recent are used so that subdirs with higher rank get properly selected.

@ruduran
Copy link
Contributor Author

ruduran commented Aug 21, 2019

Is there something I should improve on this PR?

dmd
dmd approved these changes Oct 24, 2019
View reviewed changes
Copy link

@dmd dmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.

@ruduran ruduran closed this Sep 29, 2020
@rupa rupa reopened this Sep 29, 2020
@rupa rupa merged commit 125f4dc into rupa:master Sep 29, 2020
@ruduran ruduran deleted the fix-rank-and-recent-with-common-dirs branch September 30, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmd dmd dmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruduran @dmd @rupa