-
Notifications
You must be signed in to change notification settings - Fork 9
Move to pylsp #37
base: master
Are you sure you want to change the base?
Move to pylsp #37
Conversation
Switch dependency to pylsp instead of the unmaintained pyls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW these changes look good to me.
As palantir's python-language-server is unmaintained I would very much like for pyls-black to go with the maintained implementation.
@@ -14,7 +14,7 @@ classifiers = | |||
|
|||
[options] | |||
packages = find: | |||
install_requires = python-language-server; black>=19.3b0; toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing the entry_points
update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why... It's pushed to the patch-1 branch.
No actual change (space at end of line), just trying to trigger the pull-request machine
Reverse the space at the end of the line to get back to a clean file
Alright, yeah I don't know why that didn't push through before. This whole thing should be squashed anyway so it should be one nice clean commit when done. |
Conversion from python-language-server (deprecated) to python-lsp-server by cherry picking from Github[1][2]. No conversion to PEP517, since 2023Q1 does not contain it. This will be done in a follow up commit. [1] rupert/pyls-black#37 [2] rupert/pyls-black#41 PR: 268342 Reported by: p5B2EA84B3@t-online.de MFH: 2023Q1
Conversion from python-language-server (deprecated) to python-lsp-server by cherry picking from Github[1][2]. No conversion to PEP517, since 2023Q1 does not contain it. This will be done in a follow up commit. [1] rupert/pyls-black#37 [2] rupert/pyls-black#41 PR: 268342 Reported by: p5B2EA84B3@t-online.de MFH: 2023Q1 (cherry picked from commit 4b0bcfb)
#35
Attempt to move this over.