Skip to content

Commit

Permalink
arch-kunmap_atomic-consolidate-duplicate-code-checkpatch-fixes
Browse files Browse the repository at this point in the history
Cc: Al Viro <viro@zeniv.linux.org.uk>

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
torvalds#287: FILE: arch/nds32/mm/highmem.c:50:
+EXPORT_SYMBOL(kunmap_atomic_high);

WARNING: Block comments use a trailing */ on a separate line
#453: FILE: include/linux/highmem.h:153:
+	 * handles re-enabling faults + preemption */

total: 0 errors, 2 warnings, 321 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/arch-kunmap_atomic-consolidate-duplicate-code.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Christian König <christian.koenig@amd.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Chris Zankel <chris@zankel.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Helge Deller <deller@gmx.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
  • Loading branch information
akpm00 authored and sfrothwell committed May 11, 2020
1 parent 5ab3e8e commit cd95d18
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions include/linux/highmem.h
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,10 @@ static inline void *kmap_atomic(struct page *page)

static inline void kunmap_atomic_high(void *addr)
{
/* Nothing to do in the CONFIG_HIGHMEM=n case as kunmap_atomic()
* handles re-enabling faults + preemption */
/*
* Nothing to do in the CONFIG_HIGHMEM=n case as kunmap_atomic()
* handles re-enabling faults + preemption
*/
}

#define kmap_atomic_pfn(pfn) kmap_atomic(pfn_to_page(pfn))
Expand Down

0 comments on commit cd95d18

Please sign in to comment.