fix #60 : dups class
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russHyde
commented
Jan 30, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
russHyde
force-pushed
the
dups-class2
branch
from
8bc2b03
to
b32dad2
Compare
But, `expect_silent` and `expect_error` tests should work on dupree_package() not as.data.frame(dupree_package()) to focus on errors / warnings during dupree runs, not conversion of data-structures.
Add tests for: - `as.data.frame` - `as_tibble` - only `data.frame` and `dups` can be converted to `dups` - as_dups(dups) is an identity map
`as_dups` can construct `dups` class from a `data.frame` Methods: - `as.data.frame` and `as_tibble` - `print`
Also, update docs for dupree()
russHyde
force-pushed
the
dups-class2
branch
from
b32dad2
to
17a9e5e
Compare
|
Chose not to bump the package version to 0.2.1: this is already a development version (0.2.0.9000) and the change that's introduced is a breaking change (so should move us to 0.3). But, many other changes are planned for version 0.3 (see #48 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #60
Rewrote
dupree,dupree_diranddupree_packageto return an object of classdups(rather than adata.frame).dupslist(dups_df: data.frame)where thedups_dfentry is the resultsdata.framethat was originally returned bydupreeet al (ie,file_a, file_b, block_a, block_b, ...)as.dups(x: data.frame)as_dups(x: data.frame)as_tibbleandas.data.framemethodsTODO:
printmethod (print the tibble form of a dups)READMEoutputs correctly & recompile itas.dups->as_dupsgplint_packagestyle_package[ ] bump to 0.2.1.9000