'string capitalizeAll' doesn't work for numbers

[doublec]

If I try to capitalize a string with numbers, the numbers are changed to unprintable characters:

'abcd1234defg' capitalizeAll
'ABCD????DEFG'

Tested with github master branch.

[russellallen]

Lol. Well the simplest fix is to change:

capitalizeAll = (copyMutable mapBy: [|:c| c isCapitalized ifTrue: c False: [(c asByte + capitalizationDifference) asCharacter]])

to

copyMutable mapBy: [|:c| (c isLetter not || c isCapitalized) ifTrue: c False: [(c asByte + capitalizationDifference) asCharacter]]

unless you have a better idea...

[davidungar]

Yes, that's an amusing bug! - David

…

On Sep 5, 2017, at 4:35 PM, Russell Allen ***@***.***> wrote: Lol. Well the simplest fix is to change: capitalizeAll = (copyMutable mapBy: [|:c| c isCapitalized ifTrue: c False: [(c asByte + capitalizationDifference) asCharacter]]) to copyMutable mapBy: [|:c| (c isLetter not || c isCapitalized) ifTrue: c False: [(c asByte + capitalizationDifference) asCharacter]] unless you have a better idea... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[doublec]

Looks good to me!

[russellallen]

Fixed - Commit 93b24da on dev branch