Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: unmatched InstallerType #464

Closed
1 task done
CoolPlayLin opened this issue Feb 11, 2024 · 3 comments
Closed
1 task done

[Bug]: unmatched InstallerType #464

CoolPlayLin opened this issue Feb 11, 2024 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@CoolPlayLin CoolPlayLin added bug Something isn't working help wanted Extra attention is needed labels Feb 11, 2024
@russellbanks
Copy link
Owner

This is because there isn't exactly a way to tell whether the exe is portable or an installer that isn't a known one (like Inno, Nullsoft, etc), so this was treating all portable exe's as the exe installer type. I'll change it so that if the previous installer was portable, it'll use that.

@stephengillie
Copy link

Could it check the previous manifest version?

@russellbanks
Copy link
Owner

Could it check the previous manifest version?

That's what 73e31f8 (released in Komac 2.0.4) does - if the previous installer's installer type is portable, it will use portable. Otherwise, it will use the installer type Komac has identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants