Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Komac update does not update RelativeFilePath in nested installer #537

Closed
1 task done
sitiom opened this issue Mar 23, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sitiom
Copy link

sitiom commented Mar 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

> Komac update -i lsd-rs.lsd -v 1.1.1 -u https://github.com/lsd-rs/lsd/releases/download/v1.1.1/lsd-v1.1.1-x86_64-pc-windows-msvc.zip https://github.com/lsd-rs/lsd/releases/download/v1.1.1/lsd-v1.1.1-i686-pc-windows-msvc.zip
...
# Created with komac v2.1.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json
PackageIdentifier: lsd-rs.lsd
PackageVersion: 1.1.1
InstallerType: zip
NestedInstallerType: portable
UpgradeBehavior: install
ReleaseDate: 2024-03-23
Installers:
- Architecture: x86
  NestedInstallerFiles:
  - RelativeFilePath: lsd-v1.0.0-i686-pc-windows-msvc/lsd.exe
  InstallerUrl: https://github.com/lsd-rs/lsd/releases/download/v1.1.1/lsd-v1.1.1-i686-pc-windows-msvc.zip
  InstallerSha256: 19BE09DD4B47D8CA9B01F11897CFDDD78427C79E948B3E24B4D4407824DBA5E2
  Dependencies:
    PackageDependencies:
    - PackageIdentifier: Microsoft.VCRedist.2015+.x86
- Architecture: x64
  NestedInstallerFiles:
  - RelativeFilePath: lsd-v1.0.0-x86_64-pc-windows-msvc/lsd.exe
  InstallerUrl: https://github.com/lsd-rs/lsd/releases/download/v1.1.1/lsd-v1.1.1-x86_64-pc-windows-msvc.zip
  InstallerSha256: 3E9A01B8AD0B5B468175325F97547CCB05BBC5EB81E8F962336549A56F3EAD49
  Dependencies:
    PackageDependencies:
    - PackageIdentifier: Microsoft.VCRedist.2015+.x64
ManifestType: installer
ManifestVersion: 1.6.0
...
@sitiom sitiom added bug Something isn't working help wanted Extra attention is needed labels Mar 23, 2024
@russellbanks
Copy link
Owner

russellbanks commented Mar 23, 2024

Thanks for reporting! This was identified in #479 (comment) and is fixed on main:

# Created with komac v2.1.1
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json

PackageIdentifier: lsd-rs.lsd
PackageVersion: 1.1.1
InstallerType: zip
NestedInstallerType: portable
UpgradeBehavior: install
ReleaseDate: 2024-03-23
Installers:
- Architecture: x86
  NestedInstallerFiles:
  - RelativeFilePath: lsd-v1.1.1-i686-pc-windows-msvc/lsd.exe
  InstallerUrl: https://github.com/lsd-rs/lsd/releases/download/v1.1.1/lsd-v1.1.1-i686-pc-windows-msvc.zip
  InstallerSha256: 19BE09DD4B47D8CA9B01F11897CFDDD78427C79E948B3E24B4D4407824DBA5E2
  Dependencies:
    PackageDependencies:
    - PackageIdentifier: Microsoft.VCRedist.2015+.x86
- Architecture: x64
  NestedInstallerFiles:
  - RelativeFilePath: lsd-v1.1.1-x86_64-pc-windows-msvc/lsd.exe
  InstallerUrl: https://github.com/lsd-rs/lsd/releases/download/v1.1.1/lsd-v1.1.1-x86_64-pc-windows-msvc.zip
  InstallerSha256: 3E9A01B8AD0B5B468175325F97547CCB05BBC5EB81E8F962336549A56F3EAD49
  Dependencies:
    PackageDependencies:
    - PackageIdentifier: Microsoft.VCRedist.2015+.x64
ManifestType: installer
ManifestVersion: 1.6.0

@russellbanks russellbanks closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2024
@sitiom
Copy link
Author

sitiom commented Mar 24, 2024

Ah, my bad, didn't check the existing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants