Explicitly check for case where SignatureValue is nil #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@russellhaering-okta @russellhaering Would it possible to merge this so that #48 can be closed? |
|
Fixed the missing |
moorereason
reviewed
Apr 6, 2021
|
|
|
Any idea on if/when this will get merged in? I'm having issues with this library being flagged as insecure due to it. |
|
Please merge this so https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7711 can be addressed |
|
Any update? Is there a plan to fix the vulnerability CVE-2020-7711 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the case where SignatureValue is nil in order to explicitly prevent the case reported in #48 and get the CVE closed which is currently preventing those with 'vulnerable dependancy' checks from using the library.
fixes #48