This repository has been archived by the owner on Feb 9, 2020. It is now read-only.
Use '_' instead of '.' in symbol name sanitization #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commended in the rustc code:
rustc sanitizes symbol name for GAS output, but the rule of symbol names in PTX seems to be different from GAS especially around '.'.
sanitize
function in librustc_codegen_utils replace '-' and ':' into '.', but it causes problem as reported,rust-lang#38789 (comment)
and this changes it to '_'.