Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DynClone to make the builder cloneable #205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add DynClone to make the builder cloneable #205

wants to merge 2 commits into from

Conversation

stevefan1999-personal
Copy link

This PR uses https://github.com/dtolnay/dyn-clone and modified some traits to use DynClone, so that eventually the Builder can now be Clone. Notice while the cargo test fully passes for this, this is a potentially ABI breaking change.

@notriddle
Copy link
Member

This change makes sense to me, but will definitely require a major version bump.

cc @lnicola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevefan1999-personal @notriddle