-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support single delimiter version of expect![]
#27
Conversation
320ba76
to
81e1333
Compare
The primary motivation for |
Ah, I didn't think of that. Worth noting that this isn't true for single-line expects, for which the terser syntax is most impactful. |
Yeah, so let's do this:
|
81e1333
to
883233a
Compare
This is implemented now (it requires #28). It does add some complexity, however. Let me know what you think. |
Now that we parse string literals, multiple delimiters aren't necessary.
883233a
to
b576cdd
Compare
I'm modifying this to check that `UPDATE_EXPECT` works manually.
b576cdd
to
d7c381e
Compare
Ping @matklad, in case this got lost during the holidays. Seems like |
Sorry, this felt through the cracks, it looks good to me now! bors r+ |
Build succeeded: |
Pairs of braces are no longer necessary that we parse string literals. Allow users to omit the inner
[]
.This represents a significant change to the public API, and you might have other tooling that depends on the paired braces, so I understand if you don't want it upstream. I think it reads a bit nicer, though.
Depends on #26 (although it could be separated), and is similarly lacking in integration tests for now.