Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use some ptr::addr_of_mut for taking ptr addr #109

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Use some ptr::addr_of_mut for taking ptr addr #109

merged 2 commits into from
Jul 30, 2021

Conversation

CAD97
Copy link
Collaborator

@CAD97 CAD97 commented Jul 29, 2021

Relevant to #108, but I'm not certain if it addresses the miri failure or not. (Can't check because of rust-lang/miri#705.)

Either way, this is a positive change, as previously we were creating &mut to uninitialized memory locations.

@CAD97 CAD97 requested a review from matklad July 29, 2021 21:14
@pandaman64
Copy link

I confirmed that this patch fixes #108. Thanks!

@lnicola
Copy link
Member

lnicola commented Jul 30, 2021

Can you update the version in Cargo.toml?

@CAD97
Copy link
Collaborator Author

CAD97 commented Jul 30, 2021

Version bumped

@lnicola
Copy link
Member

lnicola commented Jul 30, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 30, 2021

Build succeeded:

@bors bors bot merged commit 3d9d0a7 into rust-analyzer:master Jul 30, 2021
@lnicola
Copy link
Member

lnicola commented Jul 30, 2021

And it's published, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad Awaiting requested review from matklad

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CAD97 @pandaman64 @lnicola