Use system-deps to check for dav1d < 1.3 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise if we check for it ourselves the internal build of dav1d will not be usable. Fixes rust-av#85
sdroege
force-pushed
the
dav1d-1.3.0-version-range-check
branch
from
71948f4 to
bf2fa41
Compare
lu-zero
reviewed
Oct 31, 2023
| @@ -23,7 +23,7 @@ mod build { | |||
|
|
|||
| pub fn build_from_src( | |||
| lib: &str, | |||
| version: &str, | |||
| _version: &str, | |||
There was a problem hiding this comment.
probably would be a good idea to extend further system-deps to accomodate source tags?
There was a problem hiding this comment.
Here you could the version requirements passed in so you can theoretically build a different version or build it differently or so
lu-zero
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if we check for it ourselves the internal build of dav1d will not be usable.
Fixes #85