Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV, update v_frame, criterion and image #25

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

FreezyLemon
Copy link
Contributor

The criterion default features are kinda useless.. rayon makes the analysis after each bench faster, but even without it takes <1 sec on my laptop in energy-saving mode, and cargo_bench_support does nothing at all, AFAICT.

image default features is again rayon (not used in benches, so speed doesn't matter much) and a lot of image formats. We only need png at the moment.

@FreezyLemon
Copy link
Contributor Author

Just realized that v_frame < 0.3.8 still has the unsound code and v_frame=0.3.8 has an MSRV of 1.64. Bumped v_frame requirement and MSRV to match.

@FreezyLemon
Copy link
Contributor Author

Looks like nalgebra needs an MSRV that's even higher than 1.64. I'll hold it back for now, looking at #24 it's possible to remove it completely, so I don't want to bump MSRV for it atm.

@FreezyLemon FreezyLemon changed the title Update nalgebra, criterion and image Bump MSRV, update v_frame, criterion and image Sep 14, 2024
@shssoichiro
Copy link
Collaborator

Makes sense for now. Thanks!

@shssoichiro shssoichiro merged commit c0d398d into rust-av:main Sep 16, 2024
2 checks passed
@FreezyLemon FreezyLemon deleted the update-deps branch September 16, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants