-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to fetch number of sequences and I-th sequence from FAI index #377
Conversation
@johanneskoester Would mind reviewing my PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would rename the functions a bit, see below.
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Thanks @johanneskoester for the comments. I committed your suggested name changes. |
I need this functionality, anything holding up the PR? |
Hi @brentp, code LGTM and CI passes (allowed the CI run yesterday). I'd guess that perhaps a matching test might be what's holding this from getting merged? Up to Johannes! ;) |
Thanks @brainstorm . |
Thanks @brentp for the test code! @johanneskoester I've added added tests for the two functions in the PR. Let me know if there's further work that needs to be done to wrap up this PR. |
Awesome guys, thank you! In general: I often miss github notifications because I get so many. Just ping me via discord, twitter or email if I fail to respond in time. |
faidx.c
has two functions for retrieving the number of sequences in the FAI index (faidx_nseq
) and the name of the I-th sequence (faidx_iseq
). Previously these two functions weren't accessible throughrust-htslib
. I've added a function to access each of these into thefaidx
module.This is my first PR for
rust-htslib
, so let me know if there are any things I can improve upon in my code!