Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: memory leak in faidx when fetching sequences #455

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix!: memory leak in faidx when fetching sequences #455

merged 1 commit into from
Dec 2, 2024

Conversation

brentp
Copy link
Contributor

@brentp brentp commented Nov 22, 2024 •
edited
Loading

this changes the API. I don't see a way to still return Result<&[u8]>

@brentp
Copy link
Contributor Author

brentp commented Nov 22, 2024

cc: @johanneskoester

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11978141142

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 79.694%
Totals Coverage Status
Change from base Build 11799978853: 0.03%
Covered Lines: 2500
Relevant Lines: 3137
💛 - Coveralls

@johanneskoester johanneskoester changed the title fix: memory leak in faidx when fetching sequences fix!: memory leak in faidx when fetching sequences Dec 2, 2024
@johanneskoester
Copy link
Contributor

Thank you!

@johanneskoester johanneskoester merged commit d9fe03a into rust-bio:master Dec 2, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentp @coveralls @johanneskoester