perf(bam): Remove unnecessary heap allocation in Record::aux
#498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20109103460Details
💛 - Coveralls |
Remove the unnecessary heap allocation in `Record::aux` and `Record::remove_aux` by removing the call to `CString::new` and using the byte slice directly. The BAM tag does not need to be null terminated. Return `Error::BamAuxStringError` if the length of the tag is not equal to 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary heap allocation in
Record::auxandRecord::remove_auxby removing the call toCString::newand using thetagbyte slice directly. The BAM tag passed tohtslib::bam_aux_getdoes not need to be null terminated. ReturnError::BamAuxStringErrorif the length of the tag is not equal to 2.See bam_aux_get