Remove explicit rand dependency
#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
changed the title
rand dependencyrand dependency
rustaceanrob
force-pushed
the
8-14-rand
branch
2 times, most recently
from
fa89b0e to
82e7fe1
Compare
nyonson
reviewed
Aug 14, 2025
We only bring in `rand` explicitly for the `Rng` trait, coming from `RngCore`. The `Rng` trait is a nightmare to implement, and we only use a single call to `.fill`. If we export a far simpler trait that represents filling a 32 byte slice, then users can have a far easier time implementing this trait. This has come up in the past with this project: https://github.com/issues/recent?issue=alfred-hodler%7Cpushtx%7C3 This also removes the need for `rand` as a dependency at all, and it may be brought in through `bitcoin` (or later `secp256k1`)
rustaceanrob
force-pushed
the
8-14-rand
branch
from
82e7fe1 to
3c24a68
Compare
nyonson
reviewed
Aug 14, 2025
| } | ||
|
|
||
| #[cfg(feature = "std")] | ||
| macro_rules! impl_fill_bytes { |
There was a problem hiding this comment.
When I see macros:
But this one seems good since small and contained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only bring in
randexplicitly for theRngtrait, coming fromRngCore. TheRngtrait is a nightmare to implement, and we only use a single call to.fill. If we export a far simpler trait that represents filling a 32 byte slice, then users can have a far easier time implementing this trait. This has come up in the past with this project: alfred-hodler/pushtx#3This also removes the need for
randas a dependency at all, and it may be brought in throughbitcoin(or latersecp256k1)AFICT this can be merged now.