Implement pruneblock method and test #132
Open
+161
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GideonBature
force-pushed
the
pruneblockchain
branch
2 times, most recently
from
371f56c to
2d05895
Compare
tcharding
reviewed
Apr 28, 2025
GideonBature
force-pushed
the
pruneblockchain
branch
from
2d05895 to
cec8afd
Compare
tcharding
reviewed
Apr 29, 2025
|
Please undraft only after you've seen to all previous review suggestions. Thanks |
GideonBature
force-pushed
the
pruneblockchain
branch
from
cec8afd to
29760bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going by the conversations with tcharding for PR #116 on implementing one method at a time for easier review: This is the first method implementation
pruneblockchainwhich is a specific type that returns a standard type (numeric). Once this is approved, I’ll proceed with the remaining ones.