Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckedHrpstring::fe32_iter has an unused generic #191

Closed
apoelstra opened this issue Jul 31, 2024 · 0 comments · Fixed by #193
Closed

CheckedHrpstring::fe32_iter has an unused generic #191

apoelstra opened this issue Jul 31, 2024 · 0 comments · Fixed by #193

Comments

@apoelstra
Copy link
Member

https://docs.rs/bech32/latest/bech32/primitives/decode/struct.CheckedHrpstring.html

I don't know why the compiler doesn't complain about this but it makes the method harder to use.
tcharding added a commit to tcharding/rust-bech32 that referenced this issue Jul 31, 2024
@tcharding
Remove unused generic
d0905b0 
Turns out `clippy` does not warn for unused generics.

Fix: rust-bitcoin#191
@tcharding tcharding mentioned this issue Jul 31, 2024
Merged
tcharding added a commit to tcharding/rust-bech32 that referenced this issue Aug 6, 2024
@tcharding
Remove unused generic
725df12 
Turns out `clippy` does not warn for unused generics.

Fix: rust-bitcoin#191
apoelstra added a commit that referenced this issue Aug 6, 2024
@apoelstra
Merge #193: Remove unused generic
7e03432 
7bdabff Remove unused generic (Tobin C. Harding)

Pull request description:

  Just patch 2, draft until #192 goes in.

  Turns out `clippy` does not warn for unused generics.

  Fix: #191

ACKs for top commit:
  apoelstra:
    ACK 7bdabff successfully ran local tests; note that this is technically a breaking change

Tree-SHA512: 42fe88f886f053eaf6d68128cee9cb0f20a94afdd46dfca7bc2326726a9c2a6d010905ee97f1d2c0f13bcf620acfba1cb5463a48989c5e88f580def22ee9e5da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused generic tcharding/rust-bech32
1 participant
@apoelstra