Skip to content

Enable usage of machine set CRATES var #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcharding merged 1 commit into from
Sep 1, 2024
Merged

Enable usage of machine set CRATES var #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ci/run_task.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ main() {
# can't find the file because of the ENV var
# shellcheck source=/dev/null
. "$crates_script"
for crate in "${CRATES[@]}"; do
for crate in $CRATES; do
Copy link

@Kixunil Kixunil Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A different way to do that would be to just load the output of that command into an array. However doing that just so you can have a space in crate directory is silly, so this is fine.

verbose_say "Found crate: $crate"
done
else
Expand Down Expand Up @@ -111,7 +111,7 @@ main() {

# Build and test for each crate, done with each toolchain.
build_and_test() {
for crate in "${CRATES[@]}"; do
for crate in $CRATES; do
local test_vars_script="$REPO_DIR/$crate/contrib/test_vars.sh"

# Clean variables and also make sure they are defined.
Expand Down Expand Up @@ -287,7 +287,7 @@ build_docs_with_stable_toolchain() {
do_bench() {
verbose_say "Running bench tests for: $CRATES"

for crate in "${CRATES[@]}"; do
for crate in $CRATES; do
pushd "$REPO_DIR/$crate" > /dev/null
# Unit tests are ignored so if there are no bench test then this will just succeed.
RUSTFLAGS='--cfg=bench' cargo bench
Expand Down