Update README.md #281
Update README.md #281
Conversation
Changing localhost to actual IP address, on macOS this doesn't get interpreted correctly and there is no error to show you how to fix it.
| Given below is an example of how to connect to the Bitcoin Core JSON-RPC for a Bitcoin Core node running on `localhost` | ||
| and print out the hash of the latest block. | ||
| Given below is an example of how to connect to the Bitcoin Core JSON-RPC for a Bitcoin Core node running on `localhost` | ||
| and print out the hash of the latest block. |
There was a problem hiding this comment.
It looks like you've added trailing whitespace here. Can you instead remove all the existing trailing whitespace?
| @@ -26,7 +26,7 @@ use bitcoincore_rpc::{Auth, Client, RpcApi}; | |||
|
|
|||
| fn main() { | |||
|
|
|||
| let rpc = Client::new("http://localhost:8332", | |||
| let rpc = Client::new("http://127.0.0.1:8332", | |||
There was a problem hiding this comment.
I'm pretty skeptical of this change, TBH. It explicitly encodes ipv4 and will break if Core is not listening on ipv4.
There was a problem hiding this comment.
Understood, maybe just revert it back and add a short caveat at the bottom for those on macOS? its a pretty subtle "feature" of using this crate with macOS - kinda frustrating to run into (I had known about this actually but completely forgot).
There was a problem hiding this comment.
I'm curious if there's any other network client crate that gets this "right".
Definitely happy to add some extra text to the README suggesting that people try replacing localhost with 127.0.0.1. But I think we should leave the default example code as is.
Changing localhost to actual IP address, on macOS this doesn't get interpreted correctly and there is no error to show you how to fix it.