Skip to content

What is the point of all the hash conversion methods in ToPublicKey #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tcharding opened this issue Oct 17, 2023 · 2 comments
Closed

Comments

@tcharding
Copy link
Member

Currently all implementors of ToPublicKey just return the hash argument, what is the point of these trait methods, what am I missing? Is this trait used differently by some other consumer of rust-miniscript?

@apoelstra
Copy link
Member

Yes. The point of these is to convert from an abstract hash value to a concrete one that can be embedded in a script.

Any implementer of ToPublicKey that is not working with literal hash values will need to do a nontrivial conversion.

@apoelstra
Copy link
Member

I'm going to close this. Seems like it's "asked and answered".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants