Skip to content

fuzz: panic in Descriptor::parse_descriptor with Invalid pkh() Input in rust_miniscript #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
i-am-yuvi opened this issue Apr 10, 2025 · 2 comments · Fixed by #809
Closed

fuzz: panic in Descriptor::parse_descriptor with Invalid pkh() Input in rust_miniscript #806

i-am-yuvi opened this issue Apr 10, 2025 · 2 comments · Fixed by #809

Comments

@i-am-yuvi
Copy link

i-am-yuvi commented Apr 10, 2025 •
edited
Loading

No description provided.

@apoelstra
Copy link
Member

I believe this was closed in error (in bitcoinfuzz/bitcoinfuzz#146 it was mentioned that it's a dupe but I don't remember it).

@apoelstra apoelstra reopened this Apr 10, 2025
@i-am-yuvi
Copy link
Author

was

Thanks for reopening this!!

apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 21, 2025
@apoelstra
add regression test for rust-bitcoin#806
4ff0840 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
@apoelstra apoelstra mentioned this issue Apr 21, 2025
Merged
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 21, 2025
@apoelstra
add regression test for rust-bitcoin#806
6bff186 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 21, 2025
@apoelstra
add regression test for rust-bitcoin#806
4c6366a 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
@brunoerg brunoerg mentioned this issue Apr 23, 2025
Closed
apoelstra added a commit that referenced this issue Apr 29, 2025
@apoelstra
Merge #810: Backport of #809: fix crash in Descriptor::parse_desc
ce9c50f 
212d78a bump patch version of 12.3 (Andrew Poelstra)
4c6366a add regression test for #806 (Andrew Poelstra)
4823d86 descriptor: fix key parsing error handling in parse_desc (Andrew Poelstra)

Pull request description:

  Backports #809 and does another patch release.

ACKs for top commit:
  sanket1729:
    reACK 212d78a

Tree-SHA512: c95651f29e1bcb4e8c8036b2a74443c3fd818d39c259852d5c35f0f5ef88fbbe18b312eb7e4d29c39a4af8e9660871fbe998d86c9d21a3d502f1d9854f6f7a43
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 29, 2025
@apoelstra
add regression test for rust-bitcoin#806
2c3ec47 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 29, 2025
@apoelstra
add regression test for rust-bitcoin#806
4af754b 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 29, 2025
@apoelstra
add regression test for rust-bitcoin#806
1fed0ec 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
apoelstra added a commit that referenced this issue May 3, 2025
@apoelstra
Merge #814: Backport #809 to 0.10.x
c585c27 
06400b1 bump patch version of 10.2 (Andrew Poelstra)
1fed0ec add regression test for #806 (Andrew Poelstra)
2f21e23 descriptor: fix key parsing error handling in parse_desc (Andrew Poelstra)
0e40319 ci: update CI job to run all the fuzz tests (Andrew Poelstra)
6ff58af lib: remove some deny lints (Andrew Poelstra)

Pull request description:

  Backports #809 to 10.x. This is a direct rebase of #810 except that I added a commit with some lint fixes. (I had been avoiding this, but we've been having a lot of backports lately so I think I ought to just address it.)

  After this I will do 11.x.

ACKs for top commit:
  sanket1729:
    utACK 06400b1

Tree-SHA512: 6a30480becf20aa64e1f4528cf0d1df75bd2ddbaad95ae6bd4a3f5885624a791c7d7a77020b27675c348b2ff95467e0cb8bb42ca2c58112d7322f75480608dca
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue May 4, 2025
@apoelstra
add regression test for rust-bitcoin#806
3bf002c 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix crash in Descriptor::parse_desc found by fuzzer apoelstra/rust-miniscript
2 participants
@apoelstra @i-am-yuvi