Re-name as_public -> to_public
#377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to mutate the `self` variable, doing so makes the code subjectively harder to read. Refactor the `derive` method to not use mutable variables.
The first key in a bip32 extended key is commonly referred to as the 'master' key not the 'root' key.
According to Rust naming convention this method should use the `to_` prefix because it converts from a borrowed->owned (non-`Copy`) type. Re-name the conversion methods for converting from various private/secret keys to the associated public keys to `to_public`.
The `to_public` method on `DescriptorSinglePriv` never errors, no need to return an error type.
In an effort to make the code cleaner do some refactorings to the `to_public` method on `DescriptorXKey<bip32::ExtendedPrivKey>`. Re-factor only, no logic changes.
Do minor refactor to the `to_public` method on `DesciptorSecretKey`. Re-factor only, no logic changes.
tcharding
force-pushed
the
descriptor-key-to-public
branch
from
98a7605 to
be5e042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have been doing in
rust-bitcoinattempt to use idiomatic names for our conversion functions.Re-name the key conversion functions
as_publicto beto_publicbecause they take a borrowed type and return an owned, non-Copy type.While we are it at do a bunch of refactoring to the individual functions. Each done as a separate patch, can drop any not wanted.