WIP: Demo relative lock time module #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2022
tcharding
force-pushed
the
demo-relative-lock-time-module
branch
from
7a7282a to
f8aa659
Compare
Depend on possible code in the upcoming bitcoin 0.29.0 release. "possible" because the current "dev-branch" of bitcoin that is used contains two PRs that have not yet merged.
tcharding
force-pushed
the
demo-relative-lock-time-module
branch
from
f8aa659 to
a491468
Compare
Implement `check_older` using the new `relative::LockTime` API. This code seems upside down, I'm not sure I have the naming correct, i.e., I don't know which (`self` or arg) is doing the satisfying and which is satisfied? I believe the `<=` are going the correct direction, its the naming and which sequence value to call the 'lock' that I'm struggling with.
tcharding
force-pushed
the
demo-relative-lock-time-module
branch
from
a491468 to
a332ad9
Compare
apoelstra
added a commit
to rust-bitcoin/rust-bitcoin
that referenced
this pull request
Sep 1, 2022
da95c3a Add newtype `relative::LockTime` (Tobin C. Harding) cbfa8cf Improve lock time docs (Tobin C. Harding) 9f7d934 Move the locktime module to absolute (Tobin C. Harding) Pull request description: Patches 1 and 2 are preparation. Patch 3 adds a new `relative::LockTime` type. Please see rust-bitcoin/rust-miniscript#455 for demo of use of the new API in miniscript. ### Some links to help during review - https://medium.com/summa-technology/bitcoins-time-locks-27e0c362d7a1 - https://github.com/bitcoin/bips/blob/master/bip-0068.mediawiki - https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki ACKs for top commit: apoelstra: ACK da95c3a sanket1729: ACK da95c3a. Left a minor nit Tree-SHA512: 00137161eee354faa803f74dd33dbaaf58ced58cf54d334200be28e10281bb98cb72dff38b3205d1741b8d42100c3b8229e4cfa2155e46bb74b418b612c12dec
|
Relative lock time merged into rust-bitcoin already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a merge candidate. This PR demos (last patch only) the use of the new
relative::LockTimemodule.