-
Notifications
You must be signed in to change notification settings - Fork 169
Derive comparison traits for all secret key types #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice! cc @sanket1729 I'd like you to concept ACK before merging this |
apoelstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8e781ca
|
@apoelstra, I see that rust-secp implements |
|
Don't mind merging this. Should we wait until rust-bitcoin/rust-secp256k1#471 is resolved? |
|
Will merge after #488 |
|
@sanket1729 it looks like they appeared in rust-bitcoin/rust-secp256k1#364 where there is no discussion about them :/ maybe we forgot at that time about the pitfalls of One thing I do remember saying is that any comparisons of secret keys is likely to be leaky anyway. Like, if you put secret keys into a Another thing I do remember is that we were considering doing something crazy like, hashing the secret keys and then comparing by hash. But then somebody (kixunil?) pointed out that there are coherency requirements between |
sanket1729
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8e781ca
…all secret key types
8e781ca14f14e1528aadd0875ee4dd8ab831f57b Derive comparison traits for all secret key types (Scott Robinson)
Pull request description:
The public key types (`DescriptorPublicKey`, `DescriptorXKey`, `SinglePubKey`, and `DefiniteDescriptorKey`) all have comparison derivations.
The underlying private key types (`bitcoin::PrivateKey`, `Fingerprint`, `DerivationPath`, `DescriptorXKey`, and `ExtendedPrivKey`) all have comparison derivations.
Let's catch 'em all.
ACKs for top commit:
apoelstra:
ACK 8e781ca14f14e1528aadd0875ee4dd8ab831f57b
sanket1729:
ACK 8e781ca14f14e1528aadd0875ee4dd8ab831f57b
Tree-SHA512: d4c11acf604ee1d0b752b137833ebeb8536b73724e491dee17babe30bfea65101f9f76d87e691e7ccf4e50f4491d7b15327c1abe33154081f456840bf3719768
The public key types (
DescriptorPublicKey,DescriptorXKey,SinglePubKey, andDefiniteDescriptorKey) all have comparison derivations.The underlying private key types (
bitcoin::PrivateKey,Fingerprint,DerivationPath,DescriptorXKey, andExtendedPrivKey) all have comparison derivations.Let's catch 'em all.