Pin serde_json
#562
Merged
Pin serde_json
#562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As usual crates in the Rust ecosystem don't give a f**k about semver rules. Pin `serde_json` for 1.41 and 1.47 CI runs. Remove the pinning docs from the README and instead point devs to the CI script. (The docs are stale currently and are an unnecessary maintenance burden.)
tcharding
force-pushed
the
07-12-pin-serde_json
branch
from
9daec76 to
6f54ed9
Compare
apoelstra
approved these changes
Jul 12, 2023
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
6f54ed921be62b93ecb4c44fadeff60cac1d85ca Pin serde_json (Tobin C. Harding)
Pull request description:
Pin `serde_json` for 1.41 and 1.47 CI runs. Remove the pinning docs from the README and instead point devs to the CI script. (The docs are stale currently and are an unnecessary maintenance burden.)
ACKs for top commit:
apoelstra:
ACK 6f54ed921be62b93ecb4c44fadeff60cac1d85ca
Tree-SHA512: e53eb13a64050c2f3166ba6481cbb84767b0308739cb1cc55b1f38bbb170d051223c7ee8083819a68714d17361b7a22ae1db05d693b80fdc249b13f7488cd613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
serde_jsonfor 1.41 and 1.47 CI runs. Remove the pinning docs from the README and instead point devs to the CI script. (The docs are stale currently and are an unnecessary maintenance burden.)