policy: Do a bunch of docs fixes #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment on why we use semantic and abstract interchangeable is better placed in the `semantic` module docs.
Currently the `translate_pk` functions on `semantic::Policy` and `concrete::Policy` have exactly the same docs in the `# Examples` section, down to the usage of "abstract" in both. Direct docs readers from one function to the other to see the example.
Put some love and care into the docs in the `policy` module: - Use standard tense on functions - Use full sentences - Fix grammar/spelling/typos - Tidy up rustdoc examples - Use standard section headers (eg, `# Returns`) - Fix links - Use backticks I doubt this is perfect because fixing (and reviewing) docs is a bit boring but I'm confident it is an improvement :) There was a couple of functions that I could not re-write the docs for at the time I did this work but I've misplaced them for now.
apoelstra
approved these changes
Jul 14, 2023
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
1bd3070b0e3fca2e87a096fb5913a2db06ee7b17 policy: Put some love into the rustdocs (Tobin C. Harding)
062d1b8ba3de2081211c1dd5c7761babcdaa0bfd Remove duplicate docs (Tobin C. Harding)
0e4fa343c4771fba1e194b9b31e45777c3c2390c Move semantic/abstract docs to the semantic module (Tobin C. Harding)
Pull request description:
Three patches, the first two simple. The third is a bunch of mixed rustdoc fixes. Just sing out if this is too painful to review. I did this while attempting to understand the module better.
ACKs for top commit:
apoelstra:
ACK 1bd3070b0e3fca2e87a096fb5913a2db06ee7b17
Tree-SHA512: 907f8301ed37076dbdfe4672d0a0c2b2286513af2de54ee5b8744d8bb07b99f85bf70b3a9c6b53688af2e6ce964856c2fc2ad58f3dff649aeb2546ed97fd3e75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three patches, the first two simple. The third is a bunch of mixed rustdoc fixes. Just sing out if this is too painful to review. I did this while attempting to understand the module better.