Upgrade bitcoin dependency #618
Conversation
|
EDIT: I was salty when I wrote that, my bad. I put the comments back in. |
tcharding
force-pushed
the
10-16-upgrade-bitcoin
branch
from
dc58510
to
ad2524b
Compare
Upgrade to the latest versions the dependencies required to use `bitcoin v0.31.0-rc1`: - bitcoin: to v0.31.0 - secp256k1: to v0.28.0 - internals: to v0.2.0 - bitcoind: to v0.34.0
tcharding
force-pushed
the
10-16-upgrade-bitcoin
branch
from
ad2524b
to
e7b5db2
Compare
| @@ -614,7 +614,7 @@ impl ScriptContext for Tap { | |||
| // When the transaction sizes get close to block limits, | |||
| // some guarantees are not easy to satisfy because of knapsack | |||
| // constraints | |||
| if ms.ext.pk_cost > MAX_BLOCK_WEIGHT as usize { | |||
| if ms.ext.pk_cost as u64 > Weight::MAX_BLOCK.to_wu() { | |||
There was a problem hiding this comment.
In e7b5db2:
In a followup we should change the units of pk_cost to be Weight so we don't need to cast.
There was a problem hiding this comment.
I added it to my todo list.
|
Lots of renames. ACK from me. I hope that it was possible to do this in more than 1 commit (by fixing all the actual errors, then going through one class of deprecation message at a time). But I won't ask you to redo the PR :). |
I can definitely do better in future, I have been doing upgrades in a very inefficient, embarrassingly manual manner. Evertime I start I think to myself "its only a few changes ..." |
|
cc @sanket1729 can I go ahead and merge this? |
|
I'm gonna do it and cut a release, since I think you're busy/unavailable for a bit. |
|
@apoelstra, I am busy with some personal events for the next two weeks. Please go ahead and cut a release. |
|
Thanks! |
Upgrade
rust-bitcointo version 0.31.0 and also other required dependencies from our stack: