CI: Use specific revision of maintainer-tools #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to pull the maintainer tools repo from master otherwise we cannot patch it, we should use a specific revision. This was an oversite in the original work when introducing the maintainer tools `run_task` script. Use commit: b2ac115 Merge rust-bitcoin/rust-bitcoin-maintainer-tools#4: Add CI shell scripts
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…maintainer-tools dc7ed26003869f36aad41bb0a3cb777cf30e723b CI: Use specific revision of maintainer-tools (Tobin C. Harding) Pull request description: We don't want to pull the maintainer tools repo from master otherwise we cannot patch it, we should use a specific revision. This was an oversite in the original work when introducing the maintainer tools `run_task` script. Use commit: b2ac115 Merge rust-bitcoin/rust-bitcoin-maintainer-tools#4: Add CI shell scripts ACKs for top commit: sanket1729: ACK dc7ed26003869f36aad41bb0a3cb777cf30e723b apoelstra: ACK dc7ed26003869f36aad41bb0a3cb777cf30e723b successfully ran local tests; though once it stabilizes a bit we may want to start adding tags to maintainer-tools (maybe with just the date) to make it more visually obvious when we get out of date Tree-SHA512: d6e7f3713c5e0f93361fd2b9ff91c3d391b929d2bfb6e31fa0e706748b1ab63ee6115fb0c31a490003e826778f441c3a8126e63484459b2bbf7d3375f51d22fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to pull the maintainer tools repo from master otherwise we cannot patch it, we should use a specific revision.
This was an oversite in the original work when introducing the maintainer tools
run_taskscript.Use commit:
b2ac115 Merge rust-bitcoin/rust-bitcoin-maintainer-tools#4: Add CI shell scripts