feat: optimize pushbytes by removing unreachable minimal check #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a fuzztest which tries to decode scripts both with master and 0.12. Can wait til after #780 gets in, since that already includes a similar fuzztest for parsing expression strings. |
Working on it this week |
|
I'm gonna go ahead and merge this. Will add the fuzztest in a later PR. |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…emoving unreachable minimal check 84d1ad5932c7e1527a1aa1b46c1efde68a0f0244 feat: optimize pushbytes by removing unreachable minimal check (ChrisCho-H) Pull request description: In [rust-bitcoin](https://github.com/rust-bitcoin/rust-bitcoin/blob/aa25adfc64ea0d742ca202991140f280024aba1b/bitcoin/src/blockdata/script/push_bytes.rs#L312), `read_scriptint` checks `NonMinimalPush`, which makes an additional minimal check needless and `PushBytes` inefficient. ACKs for top commit: apoelstra: ACK 84d1ad5932c7e1527a1aa1b46c1efde68a0f0244; successfully ran local tests; yep, I think you are right Tree-SHA512: d16a199fd5caef13b4fa78584d61c7feb843accb2097b29ca7ccdabfd1cae3e5af9d54d70dc7b7b93f50809c2719f70a87cf4dbba9da53ed55d427568de9eed2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-bitcoin,
read_scriptintchecksNonMinimalPush, which makes an additional minimal check needless andPushBytesinefficient.