satisfy: change lookup_tap_key_spend_sig to take the public key
#827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have ugly and repeated code self.psbt.input[self.index]. Replace this with an accessor function which is easier to read and easier to use outside of the module.
We don't need access to the internals anywhere, and this is just a POD type with two Copy objects inside so the user can just keep them around after construction if they need access. Add an accessor for the PSBT anyway since it might be convenient. Making these fields private does not break compilation at all.
apoelstra
force-pushed
the
2025-06_sat_api
branch
from
bcdae25 to
05908d3
Compare
There is only one public key possible, but this makes the API more consistent between keyspends and script-spends, and makes it much easier for users who have a key->sig lookup table to implement satisfiers. Fixes rust-bitcoin#825
apoelstra
force-pushed
the
2025-06_sat_api
branch
from
05908d3 to
1c2800e
Compare
Member
Author
|
Because this is API-breaking I can't backport it to 12.x. It will be available in rust-miniscript 13. |
sanket1729
approved these changes
Jun 12, 2025
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
ACK 1c2800e.
I am not excited by this change. But I can see how this helps ergonomics. ACK
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ey_spend_sig` to take the public key
1c2800e2c5eeb96ae779fb5d1f506e6d53bffdd0 satisfy: change `lookup_tap_key_spend_sig` to take the public key (Andrew Poelstra)
97ef17ab50f4f2303e2d53b1eb6df696d0fff690 psbt: make PsbtInputSatisfier internals private (Andrew Poelstra)
8a93d0695b868382f9ed78929fd1bd4a11e0f80b psbt: add accessor to PsbtInputSatisfier for the input it holds (Andrew Poelstra)
Pull request description:
There is only one public key possible, but this makes the API more consistent between keyspends and script-spends, and makes it much easier for users who have a key->sig lookup table to implement satisfiers.
Fixes #825
ACKs for top commit:
sanket1729:
ACK 1c2800e2c5eeb96ae779fb5d1f506e6d53bffdd0.
Tree-SHA512: c1d1a8128823e4fa70f2dd671400825c7d3ee5d45d35b19a60cce221379373bd6ad099847246d93d62f6f10886e84e5c09a57a2f00435257af4cc8ee97348395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one public key possible, but this makes the API more consistent between keyspends and script-spends, and makes it much easier for users who have a key->sig lookup table to implement satisfiers.
Fixes #825