You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like we released a new major version of secp-sys with nothing but a MSRV bump and a cleanup of Ord. It turns out we can't do this. Whenever we update secp-sys, even if we don't actually change the C code, we need to run revendor.sh to rename all the symbols.
Right now secp-sys 0.5 and secp-sys 0.6 expose the same symbols, gated by the same links field in secp256k1-sys/Cargo.toml. Cargo will refuse to build projects that contain both of them.
Unforunately the correct way to fix this -- renaming the symbols in secp-sys 0.6 -- would require a major version bump, to 0.7; which would then require a major version bump of the main secp library, of rust-bitcoin, etc etc.
We could do the symbol rename in a point release 0.6.1, yanking 0.6.0, which potentially will break people's code that depended on the original symbol names. I'm doubtful that such people exist, and if they do, I would hope they'd be understanding. cc @TheBlueMatt what do you think?
The text was updated successfully, but these errors were encountered:
Yea, I don't know of any user who cares about the symbol names? It seems somewhat strange to be relying on the symbol names, so I don't see why we wouldn't just do an 0.6.1 and pretend it never happened.
91f1096 secp-sys: change symbol names to `0_6_1` from `0_5_0` (Andrew Poelstra)
Pull request description:
Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes#489.
This PR can be reproduced by running
./vendor-libsecp.sh depend/ 0_6_1 a1102b1
in the secp256k1-sys directory.
ACKs for top commit:
elichai:
tACK 91f1096
Tree-SHA512: 0ce5149c9c4b7b44592dec84f1a6348f62437e679c15300efe0e2cc55ced5746e6061c596c83e18428841efb7df07c5cb443a0fd81800dc2a05da9a4f7a07c1a
It looks like we released a new major version of secp-sys with nothing but a MSRV bump and a cleanup of
Ord
. It turns out we can't do this. Whenever we update secp-sys, even if we don't actually change the C code, we need to run revendor.sh to rename all the symbols.Right now secp-sys 0.5 and secp-sys 0.6 expose the same symbols, gated by the same
links
field insecp256k1-sys/Cargo.toml
. Cargo will refuse to build projects that contain both of them.Unforunately the correct way to fix this -- renaming the symbols in secp-sys 0.6 -- would require a major version bump, to 0.7; which would then require a major version bump of the main secp library, of rust-bitcoin, etc etc.
We could do the symbol rename in a point release 0.6.1, yanking 0.6.0, which potentially will break people's code that depended on the original symbol names. I'm doubtful that such people exist, and if they do, I would hope they'd be understanding. cc @TheBlueMatt what do you think?
The text was updated successfully, but these errors were encountered: