Bump libsecp256k1 #216
Closed
Bump libsecp256k1 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is configurable in upstream now. Fixes rust-bitcoin#214. So far, this just sets it to `4`. It's tempting to set it to `2` when `lowmemory` is enabled but `lowmemory` is about RAM and not about binary size. This is better addressed by a resolution of rust-bitcoin#193.
|
Closing. Will make a new PR in the next couple hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #215
bumped via the vendor script(
./vendor-libsecp.sh depend 0_1_2)and added new seckey functions while deprecating the old (see last point in notable changes)
Notable changes:
Fixes some non constant operations that were in ECDH(nothing too serious)
Remove secret-dependant non-constant time operation in ecmult_const. bitcoin-core/secp256k1#709
Fixes some harmless variable time operations:
Suppress a harmless variable-time optimization by clang in memczero bitcoin-core/secp256k1#728
Eliminate harmless non-constant time operations on secret data. bitcoin-core/secp256k1#710
Deprecate *_privkey_* functions and replace with *_seckey_*
Make ec_ arithmetic more consistent and add documentation bitcoin-core/secp256k1#701
FYI this means that we decided that changing the symbol names is not a breaking change, right? (I think it's a fair decision, we support only what we export in our public rust API, not hidden C symbols)