Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new recover_ecdsa in bench function #377

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Use the new recover_ecdsa in bench function #377

merged 1 commit into from
Jan 14, 2022

Conversation

tcharding
Copy link
Member

We recently deprecated recover in favour of recover_ecdsa but missed
one call site in benches.

@tcharding
Use the new recover_ecdsa in bench function
c7a8bbb 
We recently deprecated `recover` in favour of `recover_ecdsa` but missed
one call site in benches.
elichai
elichai approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK (haven't tested that this is the last deprecation warning)

apoelstra
apoelstra approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c7a8bbb

@apoelstra apoelstra merged commit 045896d into rust-bitcoin:master Jan 14, 2022
@tcharding tcharding deleted the rm-deprecated-call branch January 20, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@elichai elichai elichai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcharding @apoelstra @elichai