-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use range dependency for hashes v0.12.0 - v0.13.0 #649
Conversation
Nice. So, given that there are literally no changes to the codebase, I think we should change Then I'd have to think about what we want to do with the lockfiles...maybe we want a separate one for each major version of hashes? |
What is the benefit of this? |
@tcharding it lets people update their dependencies piecemeal rather than all at once. |
And I suspect it will make our own upgrade process smoother. |
Well I guess it means we don't have to do the secp upgrade and hashes upgrade in the same commit/PR, that's something. I'll add it. |
c114048
to
e65bca5
Compare
I dodged the lockfile complexity by just using 0.13.0 - I don't have the stomach for more |
There are zero code changes required to support v.0.13.0 so we elect to use a range dependency to make the upgrade path for downstream users more pleasant. Upgrade the dependency of `hashes` to be either v0.12.0 or v0.13.0 Use v0.13.0 in the recent/minimal lockfiles.
e65bca5
to
9364214
Compare
Que? I can force push later to re-run the jobs, no other clue what these fails mean. |
"unavailable for download' is probably transient. Seems safe to ignore for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9364214
Lol, sounds good. There's no particular reason to test this yet. Though we should remember to add some better tests if we ever start actually using |
There are zero code changes required to support v.0.13.0 so we elect to use a range dependency to make the upgrade path for downstream users more pleasant.
Upgrade the dependency of
hashes
to be either v0.12.0 or v0.13.0Use v0.13.0 in the recent/minimal lockfiles.