Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use range dependency for hashes v0.12.0 - v0.13.0 #649

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Aug 24, 2023

There are zero code changes required to support v.0.13.0 so we elect to use a range dependency to make the upgrade path for downstream users more pleasant.

Upgrade the dependency of hashes to be either v0.12.0 or v0.13.0

Use v0.13.0 in the recent/minimal lockfiles.

@apoelstra
Copy link
Member

Nice.

So, given that there are literally no changes to the codebase, I think we should change Cargo.toml to allow a range of versions of hashes. At least 0.12-0.13 but we could probably even move the 0.12 backward.

Then I'd have to think about what we want to do with the lockfiles...maybe we want a separate one for each major version of hashes?

@tcharding
Copy link
Member Author

So, given that there are literally no changes to the codebase, I think we should change Cargo.toml to allow a range of versions of hashes.

What is the benefit of this?

@apoelstra
Copy link
Member

@tcharding it lets people update their dependencies piecemeal rather than all at once.

@apoelstra
Copy link
Member

And I suspect it will make our own upgrade process smoother.

@tcharding
Copy link
Member Author

And I suspect it will make our own upgrade process smoother.

Well I guess it means we don't have to do the secp upgrade and hashes upgrade in the same commit/PR, that's something. I'll add it.

@tcharding tcharding force-pushed the 08-24-update-hashes branch 2 times, most recently from c114048 to e65bca5 Compare August 25, 2023 21:21
@tcharding tcharding changed the title WIP: Depend on soon-to-be-release hashes v0.13.0 Use range dependency for hashes v0.12.0 - v0.13.0 Aug 25, 2023
@tcharding
Copy link
Member Author

I dodged the lockfile complexity by just using 0.13.0 - I don't have the stomach for more cargo junk on a Saturday morning.

There are zero code changes required to support v.0.13.0 so we elect to
use a range dependency to make the upgrade path for downstream users
more pleasant.

Upgrade the dependency of `hashes` to be either v0.12.0 or v0.13.0

Use v0.13.0 in the recent/minimal lockfiles.
@tcharding tcharding force-pushed the 08-24-update-hashes branch from e65bca5 to 9364214 Compare August 25, 2023 21:25
@tcharding
Copy link
Member Author

error: component 'rust-std' for target 'mipsel-unknown-linux-gnu' is unavailable for download for channel 'stable'

Que? I can force push later to re-run the jobs, no other clue what these fails mean.

@apoelstra
Copy link
Member

"unavailable for download' is probably transient. Seems safe to ignore for now.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9364214

@apoelstra
Copy link
Member

I dodged the lockfile complexity by just using 0.13.0 - I don't have the stomach for more cargo junk on a Saturday morning.

Lol, sounds good. There's no particular reason to test this yet. Though we should remember to add some better tests if we ever start actually using bitcoin_hashes, or the ThirtyTwoByteHash trait changes.

@apoelstra apoelstra merged commit 302ff20 into rust-bitcoin:master Aug 26, 2023
@tcharding tcharding deleted the 08-24-update-hashes branch August 28, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants