Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run the nightly update job at 5 past midnight #739

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

tcharding
Copy link
Member

Currently we run the job at midnight here and in bitcoin, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.

Update to run at 5 past so this doesn't happen again.

@tcharding
Copy link
Member Author

Also done in rust-bitcoin/rust-bitcoin#3351

Kixunil
Kixunil previously approved these changes Sep 12, 2024
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 300daef

@apoelstra
Copy link
Member

Lol, I can't test anything on this repo because clippy is failing with the nightly-version that is committed since #738

I can disable clippy for now but I think instead we should fix the issue so that we don't have red Xs on everything.

@apoelstra
Copy link
Member

Needs #740.

@tcharding
Copy link
Member Author

tcharding commented Sep 12, 2024

that is committed since #738

Bollocks, hard to get good help huh :)

Currently we run the job at midnight here and in `bitcoin`, this led
recently to one using the nightly toolchain from the 10th of Sep and the
other using the toolchain from 11th of Sep.

Update to run at 5 past so this doesn't happen again.
@tcharding
Copy link
Member Author

Rebased. Added mention of UTC while I was at it.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 624fd47 successfully ran local tests

@apoelstra apoelstra merged commit d042094 into rust-bitcoin:master Sep 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants