-
Notifications
You must be signed in to change notification settings - Fork 301
Release tracking PR: v0.32.0-beta.0
#843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Based on the release tracking PR rust-bitcoin/rust-secp256k1#843 Just do the build errors, lint warnings done next.
Based on the release tracking PR rust-bitcoin/rust-secp256k1#843 Just do the build errors, lint warnings done next.
7124c05
to
6753b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The only thing blocking this is that I would like to move the I wouldn't mind any further API improvements but let's not block this release over it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6753b76
CHANGELOG.md
Outdated
* #811 | ||
* #794 | ||
* #797 | ||
* #798 | ||
* #802 | ||
* #803 | ||
* #805 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the other PRs in this changelog diff have links, why these don't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thanks man, nice one.
@tcharding seems we've lost a bit of momentum here. Wanna just cut a RC (or a beta, I guess, since we know we have more changes to do) with what we've got? |
Steven would like to stop using a git dep in ark (git deps in Cargo have terrible interactions with Nix) and I would like to practice using this new API in p2c-s2c. |
Shall we get #858 in first? |
In preparation for release add a changelog entry, bump the version, and update the lock files.
6753b76
to
fc57f9d
Compare
v0.32.0
v0.32.0-beta.0
Based on the release tracking PR rust-bitcoin/rust-secp256k1#843 Just do the build errors, lint warnings done next.
Based on the release tracking PR rust-bitcoin/rust-secp256k1#843 Just do the build errors, lint warnings done next.
Lets leave #858 out and get this released eh? |
In preparation for release add a changelog entry, bump the version, and update the lock files.