Clean up the manifest #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`homepage` is meaningless if it just points to the repo. And from the docs: A value should only be set for homepage if there is a dedicated website for the crate other than the source repository or API documentation. Do not make homepage redundant with either the documentation or repository values.
Add `exclude` to `package` section so the `tests` and `contrib` directories do not get packaged up and sent to crates.io.
As we do in `rust-bitcoin` put the `package.metadata` config down belov `dev-dependencies`. Justification is that its not that meaningful so throw it down out the way.
stevenroose
approved these changes
Sep 19, 2025
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
95d21cdbfaa97e33e2c27062719177e812d2c0b6 manifest: Move package.metadata (Tobin C. Harding)
5b0e0ff8bfdf158b307f086d20c837dd80ba03c6 manifest: Add excludes (Tobin C. Harding)
587c330dde53dcd281c546467c949d01caaa4eaa minifest: Remove homepage (Tobin C. Harding)
Pull request description:
Do a few quick clean ups to the manifest. Nothing material in here.
ACKs for top commit:
apoelstra:
ACK 95d21cdbfaa97e33e2c27062719177e812d2c0b6; successfully ran local tests
Tree-SHA512: 9ece7a1cb3cb0456b558d2812ef076fa1e888d775cc54b1961004af3fb1ce5a4ddb62504709459cac72e446555125e805e99529f6fec82abe6a5076cf4e98a47
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
95d21cdbfaa97e33e2c27062719177e812d2c0b6 manifest: Move package.metadata (Tobin C. Harding)
5b0e0ff8bfdf158b307f086d20c837dd80ba03c6 manifest: Add excludes (Tobin C. Harding)
587c330dde53dcd281c546467c949d01caaa4eaa minifest: Remove homepage (Tobin C. Harding)
Pull request description:
Do a few quick clean ups to the manifest. Nothing material in here.
ACKs for top commit:
apoelstra:
ACK 95d21cdbfaa97e33e2c27062719177e812d2c0b6; successfully ran local tests
Tree-SHA512: 9ece7a1cb3cb0456b558d2812ef076fa1e888d775cc54b1961004af3fb1ce5a4ddb62504709459cac72e446555125e805e99529f6fec82abe6a5076cf4e98a47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a few quick clean ups to the manifest. Nothing material in here.